JS-SDK not compliant with localStorage polyfill

shai-alonyH · June 15, 2016, 3:59pm

I included the info + a pull request with a fix here :

github.com/Backendless/JS-SDK

Change LocalStorage Emptiness identification

Backendless:master ← shaialon:master

opened 03:47PM - 15 Jun 16 UTC

shaialon

+3 -3

Throughout the SDK, the standard `setItem` `getItem` from the localStorage spec …are used. Line 659 is the only one that uses the assumption that localStorage inherits all of `Object`s behaviours: ``` javascript if (!('Backendless' in storage)) { ``` While this works in browsers, this could potentially create issues with various environments that use Polyfills for localStorage such as Tabris.js (I would assume also React Native, Nativescript). A simple solution to this issue is using the standard `getItem` api. ``` javascript if (!(storage.getItem('Backendless'))) { ``` You can see how this issue creates issue in Tabris.js: https://github.com/eclipsesource/tabris-js/issues/892 where effectively the cache is wiped up constantly.

ilya-veklenko · June 16, 2016, 9:45am

Hi Shai,

We’ll accept your pull request as soon as possible.
Thanks, for your contribution.

Regards, Ilya